Implement the Go Wasm plugin: bot-detect #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 38.17% 38.14% -0.03%
==========================================
Files 61 61
Lines 10412 10412
==========================================
- Hits 3975 3972 -3
- Misses 6138 6140 +2
- Partials 299 300 +1 |
|
cc @WeixinX |
|
@OnlyPiglet Please add an e2e test for it like this PR: #720 |
WeixinX
requested changes
Jan 9, 2024
👌 |
|
@OnlyPiglet hello，这块e2e test补充有进展吗 |
finished will merge this |
OnlyPiglet
requested review from
Xunzhuo,
2456868764 and
CH3CHO
as code owners
johnlanni
requested changes
Jan 31, 2024
Renz7
pushed a commit
to Renz7/higress
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Implement the Golang version of the existing CPP Wasm plugin: bot-detect
Ⅱ. Does this pull request fix one issue?
fixes #590
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews