Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi-arch building #748

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Conversation

rinfx
Copy link
Collaborator

@rinfx rinfx commented Jan 4, 2024

Ⅰ. Describe what this PR did

Support building multi-architecture higress images.

Ⅱ. Does this pull request fix one issue?

fixes #666

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@rinfx rinfx had a problem deploying to image-registry-controller January 4, 2024 09:26 — with GitHub Actions Failure
@rinfx rinfx temporarily deployed to image-registry-pilot January 4, 2024 09:26 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 4, 2024 09:26 — with GitHub Actions Inactive
@rinfx rinfx had a problem deploying to image-registry-controller January 4, 2024 11:30 — with GitHub Actions Failure
@rinfx rinfx temporarily deployed to image-registry-pilot January 4, 2024 11:30 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 4, 2024 11:30 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 4, 2024 11:54 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-controller January 4, 2024 11:54 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 4, 2024 11:54 — with GitHub Actions Inactive
.gitmodules Outdated Show resolved Hide resolved
Makefile.core.mk Outdated Show resolved Hide resolved
Makefile.core.mk Outdated Show resolved Hide resolved
@CH3CHO
Copy link
Collaborator

CH3CHO commented Jan 15, 2024

另外,也麻烦解决一下冲突。

@rinfx rinfx temporarily deployed to image-registry-controller January 26, 2024 09:01 — with GitHub Actions Inactive
@rinfx rinfx had a problem deploying to image-registry-pilot January 26, 2024 09:01 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-pilot January 26, 2024 09:01 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-pilot January 26, 2024 09:37 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-pilot January 26, 2024 09:38 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-controller January 26, 2024 09:38 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-pilot January 29, 2024 01:36 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-controller January 29, 2024 01:36 — with GitHub Actions Failure
@rinfx rinfx had a problem deploying to image-registry-pilot January 29, 2024 01:36 — with GitHub Actions Failure
@rinfx rinfx requested a review from johnlanni as a code owner January 30, 2024 08:18
@rinfx rinfx had a problem deploying to image-registry-controller January 30, 2024 08:18 — with GitHub Actions Failure
@rinfx rinfx temporarily deployed to image-registry-pilot January 30, 2024 08:18 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 30, 2024 08:18 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 30, 2024 08:36 — with GitHub Actions Inactive
@rinfx rinfx temporarily deployed to image-registry-pilot January 30, 2024 08:36 — with GitHub Actions Inactive
@rinfx rinfx had a problem deploying to image-registry-controller January 30, 2024 08:36 — with GitHub Actions Failure
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 0d93813 into feat/istio-1.19.0 Jan 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants