Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize rewrite regex #801

Merged
merged 1 commit into from Jan 25, 2024
Merged

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Jan 24, 2024

Ⅰ. Describe what this PR did

Before optimization, when the user adds the following annotation in ingress and the path contains regular expression characters (.+*?()|[]{}^$), higress will change the path type to regular expression (for compatible with the mechanism introduced by nginx).

nginx.ingress.kubernetes.io/rewrite-target: ''

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90f89cf) 38.14% compared to head (d4a1644) 38.14%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   38.14%   38.14%           
=======================================
  Files          61       61           
  Lines       10342    10342           
=======================================
  Hits         3945     3945           
  Misses       6098     6098           
  Partials      299      299           
Files Coverage Δ
pkg/ingress/kube/annotations/annotations.go 31.63% <100.00%> (ø)

@johnlanni johnlanni merged commit 073c10d into alibaba:main Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants