Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix priority type of wasmplugin #881

Merged
merged 2 commits into from Mar 26, 2024
Merged

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Mar 26, 2024

Ⅰ. Describe what this PR did

Reference: istio/api#2577

Protobuf is generating an int64 into a string, and this is generating issues with regular marshallers in order to generate a K8s resource from a proto, because K8s expects priority to be a number not a string.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni requested a review from CH3CHO as a code owner March 26, 2024 11:29
@johnlanni johnlanni merged commit a45748b into alibaba:main Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant