chore: optimize code by adding depsEqual function (#2216)

alibaba · Jun 19, 2023 · 5da4cc4 · 5da4cc4
1 parent 87b3ade
commit 5da4cc4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/packages/hooks/src/createDeepCompareEffect/index.ts b/packages/hooks/src/createDeepCompareEffect/index.ts
@@ -1,14 +1,10 @@
 import { useRef } from 'react';
 import type { DependencyList, useEffect, useLayoutEffect } from 'react';
-import isEqual from 'lodash/isEqual';
+import { depsEqual } from '../utils/depsEqual';
 
 type EffectHookType = typeof useEffect | typeof useLayoutEffect;
 type CreateUpdateEffect = (hook: EffectHookType) => EffectHookType;
 
-const depsEqual = (aDeps: DependencyList = [], bDeps: DependencyList = []) => {
-  return isEqual(aDeps, bDeps);
-};
-
 export const createDeepCompareEffect: CreateUpdateEffect = (hook) => (effect, deps) => {
   const ref = useRef<DependencyList>();
   const signalRef = useRef<number>(0);

diff --git a/packages/hooks/src/utils/depsEqual.ts b/packages/hooks/src/utils/depsEqual.ts
@@ -0,0 +1,5 @@
+import type { DependencyList } from 'react';
+import isEqual from 'lodash/isEqual';
+
+export const depsEqual = (aDeps: DependencyList = [], bDeps: DependencyList = []) =>
+  isEqual(aDeps, bDeps);
diff --git a/packages/hooks/src/utils/useDeepCompareWithTarget.ts b/packages/hooks/src/utils/useDeepCompareWithTarget.ts
@@ -1,12 +1,8 @@
-import isEqual from 'lodash/isEqual';
 import type { DependencyList, EffectCallback } from 'react';
 import { useRef } from 'react';
 import type { BasicTarget } from './domTarget';
 import useEffectWithTarget from './useEffectWithTarget';
-
-const depsEqual = (aDeps: DependencyList, bDeps: DependencyList = []) => {
-  return isEqual(aDeps, bDeps);
-};
+import { depsEqual } from './depsEqual';
 
 const useDeepCompareEffectWithTarget = (
   effect: EffectCallback,