Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useDebounce 在小程序里使用问题 #1472

Merged
merged 7 commits into from Jul 5, 2023
Merged

Conversation

crazylxr
Copy link
Collaborator

@crazylxr crazylxr commented Feb 24, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #2192

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ hchlq
✅ liuyib
❌ crazylxr
You have signed the CLA already but the status is still pending? Let us recheck it.

@crazylxr crazylxr linked an issue Feb 24, 2022 that may be closed by this pull request
@@ -0,0 +1,17 @@
import debounce from 'lodash/debounce';

function isNodeOrWeb() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(!global.Date) {
  global.Date = Date
}

如果是上面这样呢?会有啥区别?

NervJS/taro#8098 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉跟这个处理方法是一样的,都是为了把 原生对象挂到 global 里

@liuyib liuyib added this to In progress in ahooks tasks via automation Feb 23, 2023
@hchlq
Copy link
Collaborator

hchlq commented May 30, 2023

这个啥时候合进去呢

@crazylxr crazylxr merged commit a6313e9 into master Jul 5, 2023
14 checks passed
@crazylxr crazylxr deleted the fix/mini_lodash branch July 5, 2023 11:56
askwuxue pushed a commit to askwuxue/hooks that referenced this pull request Jul 29, 2023
* fix: useDebounce 在小程序里使用问题

* chore: 优化声明

---------

Co-authored-by: 云泥 <liuyibo@xylink.com>
Co-authored-by: huangcheng <huangcheng.lq@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
ahooks tasks
In progress
Development

Successfully merging this pull request may close these issues.

使用Taro开发支付宝小程序,无法使用ahooks taro中使用防抖节流会报错
5 participants