feat: useLongPress add onEnd callback #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Related: #1477 |
brickspert
reviewed
Mar 3, 2022
| @@ -45,6 +47,9 @@ function useLongPress( | |||
| if (timerRef.current) { | |||
| clearTimeout(timerRef.current); | |||
| } | |||
| if (shouldTriggerClick && isTriggeredRef.current) { | |||
There was a problem hiding this comment.
是不是只用暴露一个 onEnd，然后不管是 longPress 还是 click 结束，都调用 onEnd 就可以了？
不用区分是长按结束还是点击结束。
There was a problem hiding this comment.
是不是只用暴露一个
onEnd，然后不管是 longPress 还是 click 结束，都调用 onEnd 就可以了？不用区分是长按结束还是点击结束。
是这样～
There was a problem hiding this comment.
那就是第一个 commit 那样了～
There was a problem hiding this comment.
我想想，这里比较纠结的。
两个各有优劣的。我来优化下代码。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge