fix(useFullscreen): replace the initial value with screenfull.isFullscreen #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KangXinzhi
changed the title
crazylxr
approved these changes
Jul 18, 2022
brickspert
reviewed
Jul 19, 2022
| @@ -17,7 +17,7 @@ const useFullscreen = (target: BasicTarget, options?: Options) => { | |||
| const onExitRef = useLatest(onExit); | |||
| const onEnterRef = useLatest(onEnter); | |||
|
|
|||
| const [state, setState] = useState(false); | |||
| const [state, setState] = useState(Boolean(screenfull.isFullscreen)); | |||
There was a problem hiding this comment.
我觉得这里的默认是是有问题的。
screenfull 需要执行 screenfull.request(el) 绑定到具体的元素上，才会有实际意义的。初始化的时候都没有绑定，就没有实际意义吧。
另外 screenfull 是个单例，在所有 Hooks 是一致的，也就是如果写了两个 useFullscreen，那他们的初始化状态一定是一致的了。
如下示例，在新代码中出问题了：https://codesandbox.io/s/default-usage-forked-zg0cbw?file=/App.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link #1741
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge