-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useInfiniteScroll-完善滚动自动加载的元素要求 #1765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
实现滚动自动加载-完善target元素需要设置固定高度和overflow属性
|
brickspert
reviewed
Jul 19, 2022
brickspert
reviewed
Jul 19, 2022
👌好的
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: 砖家 ***@***.***>
发送时间: 2022年7月19日 19:11
收件人: alibaba/hooks ***@***.***>
抄送: zyhong1998 ***@***.***>, Author ***@***.***>
主题: Re: [alibaba/hooks] useInfiniteScroll-完善滚动自动加载的元素要求 (PR #1765)
@brickspert commented on this pull request.
In packages/hooks/src/useInfiniteScroll/index.zh-CN.md:
> @@ -34,7 +34,7 @@ useInfiniteScroll 的第一个参数 `service` 是一个异步函数,对这个 在无限滚动场景中,我们最常见的是滚动到底部时自动加载。通过配置以下几个属性,即可实现滚动自动加载。 -- `options.target` 指定父级元素 +- `options.target` 指定父级元素(元素需设置固定高度且设置overflow属性为滚动) ⬇️ Suggested change -- `options.target` 指定父级元素(元素需设置固定高度且设置overflow属性为滚动) +- `options.target` 指定父级元素(父级元素需设置固定高度,且支持内部滚动)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Co-authored-by: 砖家 <576679268@qq.com>
brickspert
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现滚动自动加载-完善target元素需要设置固定高度和overflow属性