Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(createUpdateEffect): Using on-demand loading will report an error. #1790

Merged
merged 3 commits into from
Aug 3, 2022
Merged

fix(createUpdateEffect): Using on-demand loading will report an error. #1790

merged 3 commits into from
Aug 3, 2022

Conversation

mushan0x0
Copy link
Contributor

@mushan0x0 mushan0x0 commented Aug 1, 2022 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close: #1791

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix createUpdateEffect will report an error when loading on demand.
🇨🇳 Chinese 修复按需加载时createUpdateEffect会报错。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@mushan0x0
Copy link
Contributor Author

@miracles1919 看看呢

miracles1919
miracles1919 reviewed Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@miracles1919 miracles1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就在 createUpdateEffect 加一个 export default 吧，以前的就不要动了

@mushan0x0
Copy link
Contributor Author

@miracles1919 可以了

@brickspert brickspert merged commit b4161d1 into alibaba:master Aug 3, 2022
@mushan0x0
Copy link
Contributor Author

@crazylxr 要不要发个版本？

@crazylxr
Copy link
Collaborator

crazylxr commented Aug 3, 2022

@crazylxr 要不要发个版本？

屯一下吧，周五吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miracles1919 miracles1919 miracles1919 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babel-plugin-import配置ahooks按需加载后createUpdateEffect报错
5 participants
@mushan0x0 @CLAassistant @crazylxr @miracles1919 @brickspert