Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useVirtualList): when overscan is 0, the list is not correct #1808

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(useVirtualList): when overscan is 0, the list is not correct #1808

wants to merge 5 commits into from
+37 −12

Conversation

Pulset
Copy link

@Pulset Pulset commented Aug 10, 2022 •
edited by liuyib

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #1538

💡 Background and solution

之前getVisibleCount和getOffset，没有考虑到滚动到一半的场景

📝 Changelog

Language Changelog
🇺🇸 English fix(useVirtualList): when overscan is 0, the list is not correct
🇨🇳 Chinese 修复当 overscan 为 0 的时候，列表数据不对的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@Pulset
Copy link
Author

Pulset commented Nov 19, 2022

@li-jia-nan Could you code review ?

@liuyib
Copy link
Collaborator

liuyib commented Mar 11, 2023

repeat: #1548

@liuyib liuyib mentioned this pull request Mar 11, 2023
Closed
18 tasks
@hchlq
Copy link
Collaborator

hchlq commented Mar 22, 2023

@crazylxr @miracles1919 一起异步看看哈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hchlq hchlq hchlq left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useVirtualList里的overscan属性设置为0时，第一条数据不会渲染
4 participants
@Pulset @CLAassistant @liuyib @hchlq