feat(useFullscreen): support page fullscreen #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个能力不错，建议单独开一个 Hooks useBrowserFullscreen，每个 Hooks 代码简单一些，感觉会更好一些。 |
|
然后 z-index 最好支持用户传入。 |
这个也没加多少代码，集成到这个hooks里面也可以吧。 |
嗯这个可以加上 |
大佬，我想了一下，这个既然是全屏了，那应该就要呈现层级是最高的，所以这个z-index应该不需要自己配置吧，所以我个人的看法是将z-index设置的更大一点，比如9999，不知道我这么想可以不？ |
然后单独开一个hooks，也没有必要吧，因为加入的代码量也不算很多，也不影响维护吧，所以就融合进useFullscreen就可以了。 |
liuyib
changed the title
liuyib
changed the title
liuyib
previously approved these changes
Mar 9, 2023
|
@crazylxr 我对原 PR 做了些优化，可以 review 了 |
crazylxr
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
暂无
💡 Background and solution
增加可以允许只设置浏览器全屏的配置。
📝 Changelog
☑️ Self Check before Merge