Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useTextSelection #1924

Merged
merged 12 commits into from Oct 27, 2022
Merged

fix: useTextSelection #1924

merged 12 commits into from Oct 27, 2022

Conversation

junjunzzz
Copy link
Contributor

@junjunzzz junjunzzz commented Oct 17, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

useTextSelection从指定区域外划词至区域内会把区域外的文字也识别了

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: useTextSlection to listen to specific area text selection
🇨🇳 Chinese 修复useTextSlection的监听特定区域文本选择

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ junjunzzz
✅ hchlq
❌ crazylxr
You have signed the CLA already but the status is still pending? Let us recheck it.

@junjunzzz
Copy link
Contributor Author

修改前:
1666015979303
修改后:采取issues 评论中第一种方法
1666016125194
效果如下:
1666016016519

@hchlq hchlq self-requested a review October 17, 2022 14:57
@hchlq
Copy link
Collaborator

hchlq commented Oct 25, 2022

@brickspert @crazylxr 辛苦有空一起帮忙看看~

@crazylxr
Copy link
Collaborator

LGTM

@crazylxr crazylxr merged commit 8e7026e into alibaba:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants