Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useClickAway): allow falsy target #1953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(useClickAway): allow falsy target #1953

wants to merge 1 commit into from
+71 −8

Conversation

KotoriK
Copy link

@KotoriK KotoriK commented Nov 3, 2022 •
edited by liuyib

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #1950

💡 Background and solution

Discuessed in #1950

📝 Changelog

Language Changelog
🇺🇸 English feat(useClickAway): allow falsy target
🇨🇳 Chinese feat(useClickAway): allow falsy target

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@KotoriK KotoriK mentioned this pull request Dec 1, 2022
Open
@liuyib liuyib self-requested a review March 6, 2023 12:17
@liuyib liuyib added this to In progress in ahooks tasks via automation Mar 6, 2023
@liuyib liuyib moved this from In progress to To do in ahooks tasks Mar 6, 2023
@liuyib liuyib moved this from To do to Review in progress in ahooks tasks Mar 9, 2023
@liuyib liuyib moved this from Review in progress to To do in ahooks tasks Mar 9, 2023
@liuyib liuyib added the v4 label Mar 11, 2023
@liuyib liuyib moved this from To do to v4 in ahooks tasks Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyib liuyib Awaiting requested review from liuyib

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
v4
Projects
No open projects
ahooks tasks
v4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[提案][useClickAway]: 能否改为targets数组中有为空的数组也可以触发onClickAway回调？
3 participants
@KotoriK @CLAassistant @liuyib