Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tslib phantom dependency problem #2013

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Conversation

sorrycc
Copy link
Contributor

@sorrycc sorrycc commented Dec 20, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

发现一个 ahooks 的幽灵依赖问题,https://unpkg.com/browse/ahooks@3.7.3/es/useRequest/src/useRequestImplement.js 使用了 tslib 却没有在 https://unpkg.com/browse/ahooks@3.7.3/package.json 中声明。

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ miracles1919
❌ sorrycc
You have signed the CLA already but the status is still pending? Let us recheck it.

@PeachScript
Copy link
Contributor

升级 father 4,doctor 命令自动帮项目检查幽灵依赖:https://github.com/umijs/father/blob/master/docs/guide/doctor.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve 'tslib' in '/cloud/source_code/node_modules/_ahooks@3.7.3@ahooks/es/useRequest/src'
5 participants