Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useHover中的fireEvent 单测问题 #2021

Merged
merged 1 commit into from Jan 4, 2023

Conversation

DomeSy
Copy link
Contributor

@DomeSy DomeSy commented Jan 3, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the fireEvent problem of unit test in useHover
🇨🇳 Chinese 修复useHover中,单元测试的fireEvent问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023

CLA assistant check
All committers have signed the CLA.

@crazylxr
Copy link
Collaborator

crazylxr commented Jan 4, 2023

你这是只加了测试用例吗?

@DomeSy
Copy link
Contributor Author

DomeSy commented Jan 4, 2023

是的,之前的测试用例有问题,fireEvent的第二个参数应该是可选项,不是fn,在fn中验证是毫无作用的

@crazylxr crazylxr changed the title fix: useHover中的fireEvent 问题 fix: useHover中的fireEvent 单测问题 Jan 4, 2023
@crazylxr crazylxr merged commit 375cc75 into alibaba:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants