Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note the default value of defaultPageSize & defaultCurrent #2041

Merged
merged 1 commit into from Feb 2, 2023
Merged

docs: note the default value of defaultPageSize & defaultCurrent #2041

merged 1 commit into from Feb 2, 2023

Conversation

xliez
Copy link
Contributor

@xliez xliez commented Feb 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

原文档有误,实际源码默认值为 const { defaultPageSize = 10, defaultCurrent = 1, ...rest } = options;

const { defaultPageSize = 10, defaultCurrent = 1, ...rest } = options;

📝 Changelog

Language Changelog
🇺🇸 English update the doc of usePagination
🇨🇳 Chinese 更新 usePagination 文档

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2023

CLA assistant check
All committers have signed the CLA.

@xliez
Copy link
Contributor Author

xliez commented Feb 1, 2023

@miracles1919
review please

@crazylxr crazylxr merged commit 056f347 into alibaba:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants