Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add lint cache #2047

Merged
merged 5 commits into from Mar 7, 2023
Merged

chore: add lint cache #2047

merged 5 commits into from Mar 7, 2023

Conversation

Simon-He95
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

crazylxr
crazylxr reviewed Feb 7, 2023
View reviewed changes
packages/hooks/src/useKeyPress/index.ts Outdated Show resolved Hide resolved
packages/hooks/src/useKeyPress/index.ts Outdated Show resolved Hide resolved
liuyib
liuyib approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@liuyib liuyib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复原了一些对代码 lint 的处理，看了下代码中还有很多没有改正的 lint warning 代码，所以准备单拉一个 PR 处理 lint warning 的代码

@liuyib liuyib changed the title chore: add lint cache & lint code chore: add lint cache Mar 6, 2023
@liuyib
Copy link
Collaborator

liuyib commented Mar 6, 2023

@crazylxr 可以合并了。lint 警告的代码我单拉一个 PR 来处理

@liuyib liuyib mentioned this pull request Mar 6, 2023
Merged
18 tasks
@crazylxr crazylxr merged commit 888d18a into alibaba:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazylxr crazylxr crazylxr left review comments

@liuyib liuyib liuyib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Simon-He95 @CLAassistant @liuyib @crazylxr