Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default value for useSize #2057

Merged
merged 6 commits into from Feb 19, 2023
Merged

fix: add default value for useSize #2057

merged 6 commits into from Feb 19, 2023

Conversation

li-jia-nan
Copy link
Collaborator

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: add default value for useSize
🇨🇳 Chinese -

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@crazylxr crazylxr added this to Review in progress in ahooks tasks Feb 15, 2023
@crazylxr crazylxr merged commit f3ecb7d into master Feb 19, 2023
ahooks tasks automation moved this from Review in progress to Done Feb 19, 2023
@crazylxr crazylxr deleted the useSize branch February 19, 2023 09:20
@liuyib liuyib mentioned this pull request Feb 20, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linhf123 linhf123 linhf123 left review comments

@crazylxr crazylxr crazylxr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
ahooks tasks
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useSize
3 participants
@li-jia-nan @crazylxr @linhf123