Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update useKeyPress docs #2058

Closed
wants to merge 2 commits into from
Closed

docs: update useKeyPress docs #2058

wants to merge 2 commits into from

Conversation

li-jia-nan
Copy link
Collaborator

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English docs: update useKeyPress docs
🇨🇳 Chinese -

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@liuyib
Copy link
Collaborator

liuyib commented Feb 13, 2023

FAQ 不够严谨,我这边测试到的结果如下:

Mac 系统下(Windows、Linux 系统没测)、Chrome 浏览器:

  1. 按下 Command 键后,再按其他任何键(另一个 Command 键除外)都不会触发 keyup 回调
  2. 按下 Alt 键后,其他大部分按键可以触发 keyup,部分不能

@crazylxr @li-jia-nan

@crazylxr
Copy link
Collaborator

FAQ 不够严谨,我这边测试到的结果如下:

Mac 系统下(Windows、Linux 系统没测)、Chrome 浏览器:

  1. 按下 Command 键后,再按其他任何键(另一个 Command 键除外)都不会触发 keyup 回调
  2. 按下 Alt 键后,其他大部分按键可以触发 keyup,部分不能

@crazylxr @li-jia-nan

要不你这边来提个 PR ,帮忙完善一下文档?

@liuyib
Copy link
Collaborator

liuyib commented Feb 15, 2023

FAQ 不够严谨,我这边测试到的结果如下:
Mac 系统下(Windows、Linux 系统没测)、Chrome 浏览器:

  1. 按下 Command 键后,再按其他任何键(另一个 Command 键除外)都不会触发 keyup 回调
  2. 按下 Alt 键后,其他大部分按键可以触发 keyup,部分不能

@crazylxr @li-jia-nan

要不你这边来提个 PR ,帮忙完善一下文档?

我找时间在三个系统,多个浏览器下测试测试,把测试结果反馈到这里,你们来作参考。

@crazylxr
Copy link
Collaborator

那这个 pr 我就先关了哈,等 @liuyib 你的 pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useKeyPress按住command键,其他按键触发keyup时,没有调用回调函数。
3 participants