Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new hook "useBounding" #2063

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: add new hook "useBounding" #2063

wants to merge 18 commits into from

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Feb 14, 2023 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #2042

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add new hook "useBounding"
🇨🇳 Chinese 添加新的 hook “useBounding”

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@liuyib
Copy link
Collaborator Author

liuyib commented Feb 16, 2023 •
edited

@crazylxr @luo3house 代码、单测、文档已经全部编写完毕，可以 review 了

This was referenced Mar 11, 2023
Closed
Closed
@liuyib
Copy link
Collaborator Author

liuyib commented Mar 11, 2023

repeat: #1874

@crazylxr
Copy link
Collaborator

这个 v4 的时候重新整合一下。

@crazylxr crazylxr added the v4 label Apr 17, 2023
KMNowak
KMNowak suggested changes May 27, 2023
View reviewed changes
packages/hooks/src/useBounding/index.ts Outdated Show resolved Hide resolved
packages/hooks/src/useBounding/index.ts Outdated Show resolved Hide resolved
packages/hooks/src/useBounding/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzn1 chenzn1 chenzn1 left review comments

@luo3house luo3house luo3house left review comments

@KMNowak KMNowak KMNowak requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useBoundingRect
6 participants
@liuyib @crazylxr @chenzn1 @KMNowak @luo3house @li-jia-nan