Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useCookieState): the update will not take effect before unmount #2074

Merged
merged 2 commits into from Feb 23, 2023

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Feb 21, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2073

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English The update will not take effect before unmount
🇨🇳 Chinese 更新 cookie 后卸载组件,则更新不会生效

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@liuyib
Copy link
Collaborator Author

liuyib commented Feb 21, 2023

ready for review @crazylxr

@crazylxr crazylxr added this to Review in progress in ahooks tasks Feb 22, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ liuyib
❌ crazylxr
You have signed the CLA already but the status is still pending? Let us recheck it.

@crazylxr crazylxr merged commit e7682c1 into alibaba:master Feb 23, 2023
ahooks tasks automation moved this from Review in progress to Done Feb 23, 2023
@liuyib liuyib deleted the fix_useCookieState branch February 23, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants