Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useReactive): allow the field value of initialState to be a special object #2079

Merged
merged 15 commits into from Mar 6, 2023
Merged

fix(useReactive): allow the field value of initialState to be a special object #2079

merged 15 commits into from Mar 6, 2023

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Feb 25, 2023 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close: #2080
close: #1024

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English allow the field value of initialState to be a special object
🇨🇳 Chinese 允许 initialState 的字段值为一个特殊的 JS 对象

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@liuyib liuyib changed the title fix(useReactive): don't proxy react element to prevent throwing exception fix(useReactive): don't proxy React element to prevent throwing exception Feb 25, 2023
@liuyib
Copy link
Collaborator Author

liuyib commented Feb 25, 2023 •
edited

@crazylxr ready for review

@liuyib liuyib changed the title fix(useReactive): don't proxy React element to prevent throwing exception fix(useReactive): allow the field value of initialState to be a special object Feb 26, 2023
@liuyib
Copy link
Collaborator Author

liuyib commented Feb 26, 2023

@crazylxr ready for review.

@liuyib liuyib mentioned this pull request Feb 26, 2023
Closed
@liuyib liuyib requested a review from crazylxr February 28, 2023 02:15
@crazylxr crazylxr merged commit c607523 into master Mar 6, 2023
@crazylxr crazylxr deleted the fix_useReactive_dom branch March 6, 2023 11:59
This was referenced May 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luo3house luo3house luo3house left review comments

@crazylxr crazylxr crazylxr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useReactive 关于 RegExp 的bug useReactive can't set formData to state
3 participants
@liuyib @crazylxr @luo3house