Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): missing @babel/runtime in cjs #2095

Merged
merged 8 commits into from Mar 7, 2023

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Mar 5, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #2093

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English missing @babel/runtime in cjs
🇨🇳 Chinese 使用 require 导入时缺少 @babel/runtime 依赖

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@miracles1919
Copy link
Collaborator

lock 更新下,不然 CI 过不了

@liuyib
Copy link
Collaborator Author

liuyib commented Mar 6, 2023

应该不是 lock 的问题,我再排查下

确实是 lock 的问题,现在可以了

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ liuyib
❌ crazylxr
You have signed the CLA already but the status is still pending? Let us recheck it.

@crazylxr crazylxr merged commit a1f8fd8 into master Mar 7, 2023
@crazylxr crazylxr deleted the chore_add_miss_deps_@babel/runtime branch March 7, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing dependency @babel/runtime in cjs build, under lib folder
5 participants