Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useBoolean): default value is converted to boolean type #2108

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix(useBoolean): default value is converted to boolean type #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/hooks/src/useBoolean/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,18 @@ describe('useBoolean', () => {
});

it('test on default value', () => {
const hook = setUp(true);
expect(hook.result.current[0]).toBe(true);
const hook1 = setUp(true);
expect(hook1.result.current[0]).toBe(true);
const hook2 = setUp();
expect(hook2.result.current[0]).toBe(false);
// @ts-ignore
const hook3 = setUp(0);
expect(hook3.result.current[0]).toBe(false);
// @ts-ignore
const hook4 = setUp('');
expect(hook4.result.current[0]).toBe(false);
// @ts-ignore
const hook5 = setUp('hello');
expect(hook5.result.current[0]).toBe(true);
});
});
2 changes: 1 addition & 1 deletion packages/hooks/src/useBoolean/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export interface Actions {
}

export default function useBoolean(defaultValue = false): [boolean, Actions] {
const [state, { toggle, set }] = useToggle(defaultValue);
const [state, { toggle, set }] = useToggle(!!defaultValue);

const actions: Actions = useMemo(() => {
const setTrue = () => set(true);
Expand Down