fix(useInfiniteScroll): reload data should be latest #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyib
changed the title
| @@ -159,6 +159,35 @@ describe('useInfiniteScroll', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('reload data should be latest', async () => { | |||
There was a problem hiding this comment.
这里主要测试的是最终结果没问题，那个结果态还不太好 mock
There was a problem hiding this comment.
@miracles1919 我试了下 cross-env REACT_MODE=strict jest packages/hooks/src/useInfiniteScroll/__tests__/index.test.ts 执行时，我特定写了个 useEffect，好像只运行一次，符合预期么
There was a problem hiding this comment.
我知道了，引用的 renderHook 还是之前的，strict 模式要从 utils 引入，应该是之前 strict 问题比较多，所以没改
miracles1919
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a bugFix
🔗 Related issue link
close #1970
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge