Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(createUseStorageState): usage of setState is inconsistent with docs #2149

Merged
merged 5 commits into from Apr 17, 2023

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Apr 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

Refer to the doc, we can clear localStorage/sessionStorage by:

image

but actually, the setState does not meet the above requirements.

📝 Changelog

Language Changelog
🇺🇸 English fix(createUseStorageState): usage of setState is inconsistent with docs
🇨🇳 Chinese fix(createUseStorageState): setState 的用法和文档不一致

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@crazylxr crazylxr merged commit bf4e0ef into master Apr 17, 2023
15 checks passed
@crazylxr crazylxr deleted the fix_storage_type branch April 17, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants