Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: fix time lag causing no countdown #2150

Merged
merged 4 commits into from Apr 11, 2023
Merged

Conversation

c0dedance
Copy link
Contributor

@c0dedance c0dedance commented Apr 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix time lag causing no countdown
🇨🇳 Chinese 修复时间滞后导致没有倒计时

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ li-jia-nan
❌ c0dedance
You have signed the CLA already but the status is still pending? Let us recheck it.

@c0dedance c0dedance changed the title fix: time error fix: fix time lag causing no countdown Apr 8, 2023
@KurumiRin
Copy link

用new Date(new Date().getFullYear(), 12, 31)替代?否则每年都需要更新

@c0dedance
Copy link
Contributor Author

用new Date(new Date().getFullYear(), 12, 31)替代?否则每年都需要更新

聪明

@c0dedance
Copy link
Contributor Author

2022-12-31 24:00:00的表达可能有问题,是否需要一同修改
因为2022-12-31 23:59:59 下一秒=> 2023-01-01 00:00:00
image

@li-jia-nan
Copy link
Collaborator

嗯,24:00:00 改成 23:59:59 吧,年份写死 2023 就行了,demo 里面不用写的很复杂

@li-jia-nan
Copy link
Collaborator

然后 <p> 标签外层的 <> 标签好像没用,可以顺便删掉

@c0dedance
Copy link
Contributor Author

嗯,24:00:00 改成 23:59:59 吧,年份写死 2023 就行了,demo 里面不用写的很复杂

ok,明白了

@li-jia-nan li-jia-nan changed the title fix: fix time lag causing no countdown demo: fix time lag causing no countdown Apr 9, 2023
@li-jia-nan
Copy link
Collaborator

还是改成动态的了

@crazylxr crazylxr merged commit 8816e30 into alibaba:master Apr 11, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants