Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix useWebSocket error (#2176) #2177

Merged
merged 4 commits into from Jun 6, 2023
Merged

fix useWebSocket error (#2176) #2177

merged 4 commits into from Jun 6, 2023

Conversation

YinDongFang
Copy link
Contributor

@YinDongFang YinDongFang commented Apr 26, 2023 •
edited by liuyib

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #2176

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1. fix useWebSocket error when initial socketUrl is empty 2. fix useWebSocket unlimited reconnect when update socketUrl
🇨🇳 Chinese 1. 修复useWebSocket初始socketUrl参数为空时报错 2. 修复useWebSocket更新socketUrl时无限重新连接

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@crazylxr
Copy link
Collaborator

crazylxr commented Jun 6, 2023

LGTM

@crazylxr crazylxr merged commit 52bc820 into alibaba:master Jun 6, 2023
8 checks passed
@liuyib liuyib mentioned this pull request Jun 6, 2023
Closed
@zwmmm
Copy link

zwmmm commented Jun 20, 2023

这个功能还没有发布么 最新版本的 3.7.7 还是没有判断空的url

@liuyib
Copy link
Collaborator

liuyib commented Jun 20, 2023 •
edited

这个功能还没有发布么 最新版本的 3.7.7 还是没有判断空的url

代码合并到主分支了，没赶上 3.7.7 发版。下个版本就有了哈

@happy-windman
Copy link

请问大佬大概什么时候发布新版本

@liuyib
Copy link
Collaborator

liuyib commented Jun 21, 2023

请问大佬大概什么时候发布新版本

这两天发一版，应该明天会发

@liuyib
Copy link
Collaborator

liuyib commented Jun 25, 2023

新版 v3.7.8 已发布 @happy-windman @zwmmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyib liuyib liuyib left review comments

@crazylxr crazylxr crazylxr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useWebSocket初始socketUrl为空报错，更新socketUrl导致无限重连
5 participants
@YinDongFang @crazylxr @zwmmm @liuyib @happy-windman