feat(useThrottleFn/useDebounceFn): support requestAnimationFrame #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liuyib
changed the title
liuyib
changed the title
liuyib
approved these changes
Sep 26, 2023
|
Thank you for your contribution. |
liuyib
approved these changes
Sep 26, 2023
liuyib
reviewed
Dec 18, 2023
| @@ -17,7 +17,8 @@ function useDebounceFn<T extends noop>(fn: T, options?: DebounceOptions) { | |||
|
|
|||
| const fnRef = useLatest(fn); | |||
|
|
|||
| const wait = options?.wait ?? 1000; | |||
| // https://github.com/alibaba/hooks/issues/2331 | |||
| const wait = 'wait' in options ? options.wait : 1000; | |||
|
|
|||
There was a problem hiding this comment.
Seems to have "breaking changes", advise to do in v4
There was a problem hiding this comment.
存在 breaking changes 的：
旧行为：
// 设置
{ wait: undefined }
// 被处理成
{ wait: 1000 }新行为：
// 设置
{ wait: undefined }
// 被处理成
{ wait: undefined }
|
这个当做 v4 的 feature， @zhe-he 把 pr 往 v4 上合呢。 |
|
刚看见这条通知，看见基础分支已被更新成v4了，好像不需要我做啥😊 |
liuyib
changed the title
liuyib
changed the title
liuyib
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2331