Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(useInfiniteScroll): fix api table #2433

Merged
merged 4 commits into from Jan 10, 2024
Merged

Conversation

marunrun
Copy link
Contributor

@marunrun marunrun commented Jan 3, 2024

fix useInfiniteScroll Result table style

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

fix useInfiniteScroll  Result table style
@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

@liuyib
Copy link
Collaborator

liuyib commented Jan 8, 2024

Markdown 表格的格式是 prettier 自动处理的,不用手动改哈~

@liuyib liuyib closed this Jan 8, 2024
@marunrun
Copy link
Contributor Author

marunrun commented Jan 8, 2024

Markdown 表格的格式是 prettier 自动处理的,不用手动改哈~

CleanShot 2024-01-08 at 14 30 57@2x

https://ahooks.js.org/hooks/use-infinite-scroll#result
我看文档上 这一块儿都是乱的

@liuyib
Copy link
Collaborator

liuyib commented Jan 8, 2024

可能之前有人更新文档,语法符号没匹配上

@liuyib liuyib reopened this Jan 8, 2024
@liuyib liuyib changed the title Update useInfiniteScroll/index.zh-CN.md docs(useInfiniteScroll): fix api table Jan 8, 2024
@liuyib
Copy link
Collaborator

liuyib commented Jan 8, 2024

Markdown 的 table 格式化有时候感觉比较鸡肋,如果能把 .vscode 目录推到仓库里,并且设置 .md 文件不换行:
image
那么格式化 table 挺好的,美观还能减少出错:
image

否则文本换行,看到的结果是一团糟,还不如不格式化:
image

@crazylxr 这块咋解决呢?是全部 Markdown table 禁用格式化?还是把 .vscode 设置上 md 文件不换行(这个方式只对 VS Code 用户生效)?

@crazylxr crazylxr merged commit 4c9dbc1 into alibaba:master Jan 10, 2024
8 checks passed
byethewind pushed a commit to byethewind/hooks that referenced this pull request Feb 26, 2024
* Update useInfiniteScroll/index.zh-CN.md

fix useInfiniteScroll  Result table style

* docs: format table

* docs: fix syntax

* docs: update

---------

Co-authored-by: liuyib <1656081615@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants