Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useInViewport): el is not empty #2476

Merged
merged 1 commit into from Feb 26, 2024

Conversation

GetWebHB
Copy link
Contributor

@GetWebHB GetWebHB commented Feb 13, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@crazylxr
Copy link
Collaborator

没太理解为什么会为空?

@GetWebHB
Copy link
Contributor Author

我的意思是:前面已经判断过了,当els.foreach的时候,此时的el肯定有值,所以用了断言

@crazylxr
Copy link
Collaborator

LGTM

@crazylxr crazylxr merged commit 8eb174a into alibaba:master Feb 26, 2024
8 checks passed
byethewind pushed a commit to byethewind/hooks that referenced this pull request Feb 26, 2024
raotaohub pushed a commit to raotaohub/hooks that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants