Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

用重载完善 useEventListener 声明 #741

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

huruji
Copy link
Contributor

@huruji huruji commented Nov 20, 2020

用重载完善 useEventListener 声明

Change-Id: Idbbf1598cc7309f782ca1032b3d43d3eee130796
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 20, 2020

😭 Deploy PR Preview 2df1be4 failed. Build logs

🤖 By surge-preview

Copy link
Collaborator

@awmleer awmleer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brickspert
Copy link
Collaborator

CI 没过,需要检查下

@awmleer
Copy link
Collaborator

awmleer commented Nov 23, 2020

src/useHover/index.ts(22,7): error TS2769: No overload matches this call.
  The last overload gave the following error.
    Type 'BasicTarget<HTMLElement>' is not assignable to type 'Window | undefined'.
      Type 'null' is not assignable to type 'Window | undefined'.
src/useHover/index.ts(33,7): error TS2769: No overload matches this call.
  The last overload gave the following error.
    Type 'BasicTarget<HTMLElement>' is not assignable to type 'Window | undefined'.
      Type 'null' is not assignable to type 'Window | undefined'.

@huruji
Copy link
Contributor Author

huruji commented Nov 23, 2020

OK,我检查一下先

@awmleer awmleer self-assigned this Feb 23, 2021
@awmleer awmleer added the enhancement Improvement or optimization label Feb 24, 2021
@awmleer awmleer merged commit 3a7b7d5 into alibaba:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants