feat: 添加 useSafeState hook #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
测试用例补一下？ |
|
感觉叫 |
改了改了~ |
@awmleer 这个能合并么 |
要是没啥问题合一下? 不然我本地还得再维护一份代码 ~~~ @awmleer |
brickspert
reviewed
Feb 2, 2021
| @@ -23,7 +23,10 @@ export default function useControllableValue<T>(props: Props = {}, options: Opti | |||
| const value = props[valuePropName]; | |||
|
|
|||
| const [state, setState] = useState<T | undefined>(() => { | |||
| if (valuePropName in props) { | |||
| if ( | |||
There was a problem hiding this comment.
这个地方会导致 defaultValue 不生效吧
There was a problem hiding this comment.
是的，这个地方的处理跟 antd 的处理有偏差吧，存在应该指的是初次值不为 undefined 的吧
There was a problem hiding this comment.
@awmleer @brickspert https://stackblitz.com/edit/react-nsofly?file=index.js 那 antd 的这个行为符合预期么 ~~
There was a problem hiding this comment.
@brickspert 老哥 这个地方是不是再考虑一下？目前 antd 的组件(以及原生 input )针对首次 value 为 undefined 的时候 defaultValue 都会生效，按照 useControllableValue 目前的实现。无法跟 antd 完美的结合呀。~~
还有一些小问题，另外就是不要改 useControllableValue ~~ 感觉这个 Hooks 有点细碎，不确定会不会造成选择困难症。 |
turkyden
reviewed
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
避免组件卸载后，异步回调中执行 setState