Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipam: pre decouple and recycle all IPs for Completed or Evicted pods #84

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

mars1024
Copy link
Collaborator

Pull Request Description

Describe what this PR does / why we need it

ref to #82

Does this pull request fix one issue?

#82

Describe how you did it

NONE

Describe how to verify it

NONE

Special notes for reviews

NONE

@mars1024 mars1024 force-pushed the feat/pre-decouple branch 2 times, most recently from b7286eb to 76eef31 Compare September 28, 2021 06:44
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #84 (567f062) into release-v0.3.0 (ef95870) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v0.3.0      #84      +/-   ##
==================================================
- Coverage           17.31%   17.18%   -0.14%     
==================================================
  Files                  32       32              
  Lines                2616     2636      +20     
==================================================
  Hits                  453      453              
- Misses               2106     2126      +20     
  Partials               57       57              
Flag Coverage Δ
unittests 17.18% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/ipam/pod.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef95870...567f062. Read the comment docs.

pkg/ipam/store/store.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@hhyasdf hhyasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hhyasdf hhyasdf merged commit 616d93c into release-v0.3.0 Sep 28, 2021
@hhyasdf hhyasdf deleted the feat/pre-decouple branch September 28, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants