feat: add https list #5011
Merged
feat: add https list #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-next #5011 +/- ##
================================================
+ Coverage 29.60% 29.64% +0.03%
================================================
Files 192 192
Lines 4894 4898 +4
Branches 1174 1175 +1
================================================
+ Hits 1449 1452 +3
- Misses 3183 3184 +1
Partials 262 262
|
wjq990112
approved these changes
Dec 3, 2021
ClarkXia
reviewed
Dec 7, 2021
| const { commandArgs } = context; | ||
| // Only generate https cert for web task | ||
| if (config.get('name') !== 'web') return; | ||
| let httpsConfig; | ||
| if (https) { | ||
| try { | ||
| const hosts = ['localhost']; | ||
| const hosts = ['localhost', ...getValue('HTTPS_URL_LIST')]; |
There was a problem hiding this comment.
边界 case 处理下，可能未设置 HTTPS_URL_LIST 的值
ClarkXia
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyCliOptions.rax|.ice