Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: docker event listener fd leak and event lost #529

Closed
yyuuttaaoo opened this issue Nov 25, 2022 · 0 comments · Fixed by #530
Closed

[BUG]: docker event listener fd leak and event lost #529

yyuuttaaoo opened this issue Nov 25, 2022 · 0 comments · Fixed by #530
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yyuuttaaoo
Copy link
Collaborator

Describe the bug
Fd will leak if connection to docker.sock lost.
Details here: fsouza/go-dockerclient#911

Event may lost if lots of container are created concurrently

$ sudo kubectl apply -f deploy.yaml 
$ ./docker-event 2>&1 | tee events.log
2022/10/23 17:11:09.395169 Unofficial: docker event listener start
2022/10/23 17:11:09.395706 Official: docker event listener start
$ sudo kubectl scale --replicas=10 -n sls-test deployment/centos

Result

# grep start events.log | grep Official | grep centos| wc -l
20 #包括pause容器,符合预期
# grep start events.log | grep CRI | grep centos  | wc -l
10 #不包括pause容器,符合预期
# grep start events.log | grep Unofficial | grep centos| wc -l
17 #包括pause容器,漏了3个事件
@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Nov 25, 2022
@yyuuttaaoo yyuuttaaoo self-assigned this Nov 25, 2022
@yyuuttaaoo yyuuttaaoo added this to the v1.3 milestone Nov 25, 2022
yyuuttaaoo added a commit to yyuuttaaoo/ilogtail that referenced this issue Nov 25, 2022
@yyuuttaaoo yyuuttaaoo linked a pull request Dec 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant