Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blacklist config error cannot be logged #1218

Merged
merged 1 commit into from Nov 3, 2023
Merged

fix: blacklist config error cannot be logged #1218

merged 1 commit into from Nov 3, 2023

Conversation

RoboticShark
Copy link
Contributor

@RoboticShark RoboticShark commented Nov 3, 2023 •
edited

Before

[2023-11-03 07:54:13.237251]    [error] [100525]        /workspaces/ilogtail/core/config_manager/ConfigManagerBase.cpp:1091          failed to parse config logname:log        Reason:Unknown

After

[2023-11-03 08:57:57.424563]    [error] [2853]  /workspaces/ilogtail/core/config_manager/ConfigManagerBase.cpp:1085          failed to parse config logname:log        Reason:filepath_blacklist item must be absolute path, file path: *-data-*.log

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@yyuuttaaoo yyuuttaaoo added this to the v1.8 milestone Nov 3, 2023
@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Nov 3, 2023
@yyuuttaaoo yyuuttaaoo merged commit 465d47d into alibaba:main Nov 3, 2023
20 checks passed
yyuuttaaoo pushed a commit that referenced this pull request Nov 8, 2023
@RoboticShark @yyuuttaaoo
fix: blacklist config error cannot be logged (#1218)
f4f3f0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RoboticShark @CLAassistant @yyuuttaaoo