fix: Resolve crash issue during Apsara log parsing and integrate AddressSanitizer into debug build configuration #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyuuttaaoo
changed the title
yyuuttaaoo
changed the title
yyuuttaaoo
changed the title
messixukejia
reviewed
Dec 7, 2023
messixukejia
approved these changes
Dec 7, 2023
yyuuttaaoo
added a commit
that referenced
this pull request
Dec 7, 2023
…essSanitizer into debug build configuration (#1253) * fix: crash when parsing apsara log * refine git workflow * fix workflow go env * fix workflow * fix workflow name * link tcmalloc if CMakeBuildType is not Debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing apsara log, there will be a stack-buffer-overflow in function
logtail::LogParser::GetApsaraLogMicroTime(char const*) /workspaces/ilogtail-yyuuttaaoo/core/parser/LogParser.cpp which may lead to crash.
The issue is resolved by ensuring timeStr terminate with \0.
To prevent similar issues from recurring, address sanitizer has been added to the debug build configuration.