Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static container #906

Merged
merged 6 commits into from Jun 7, 2023
Merged

fix static container #906

merged 6 commits into from Jun 7, 2023

Conversation

linrunqi08
Copy link
Collaborator

@linrunqi08 linrunqi08 commented Jun 5, 2023

updateContainer原设计上不支持覆盖更新,只支持增量更新。
静态文件读取容器信息场景下,如果静态文件有变更,重复读取静态文件,会导致sandbox信息丢失。

@yyuuttaaoo yyuuttaaoo added this to the v1.6 milestone Jun 5, 2023
Copy link
Collaborator

@EvanLjp EvanLjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/helper/docker_center.go Show resolved Hide resolved
pkg/helper/docker_center_test.go Outdated Show resolved Hide resolved
@yyuuttaaoo yyuuttaaoo merged commit b2ccc4e into main Jun 7, 2023
21 checks passed
@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Jun 7, 2023
@messixukejia messixukejia deleted the feature/taiye/fix_static_container branch August 16, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants