enhance prometheus sharding in kubernetes #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linrunqi08
reviewed
Jun 16, 2023
| logger.Error(p.context.GetRuntimeContext(), "KUBE_PROMETHEUS_ALARM", "read workload name err", p.workloadName) | ||
| return false | ||
| } | ||
| for i := 0; i < 3; i++ { |
There was a problem hiding this comment.
加了一下，如果一直失败，会退化成1副本，最差是采集重复
| func (p *ServiceStaticPrometheus) StartKubeReloadScraper() { | ||
| go func() { | ||
| ticker := time.NewTicker(time.Second * 10) | ||
| for { |
There was a problem hiding this comment.
这个功能是默认开的？ daemonset每个节点都会调用？
There was a problem hiding this comment.
是不是只要statefulset就可以了
There was a problem hiding this comment.
ILOGTAIL_PROMETHEUS_CLUSTER_REPLICAS 有环境变量控制
There was a problem hiding this comment.
ILOGTAIL_PROMETHEUS_CLUSTER_REPLICAS不是老的模式吗？新的模式怎么控制？
linrunqi08
approved these changes
Aug 2, 2023
messixukejia
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
历史使用ILOGTAIL_PROMETHEUS_CLUSTER_REPLICAS 环境变量扩缩容，但是环境变量无法感知scale 操作的扩缩容，因此分片模式运行时可能倒是抓取重复问题，目前使用动态k8s api 获取扩缩容的变化