Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复一些小 bug #21

Closed
wants to merge 3 commits into from
Closed

Conversation

virusdefender
Copy link

@virusdefender virusdefender commented May 26, 2021

修复了一些小问题

  • 解析到的 collate 是 = 的问题(偏移差 1)
  • 字段有单独声明的 charset 的时候,解析错误的问题(取错了参数,应该取字段的 MaxBytesPerChar 实际是用的表的)
  • 字段没声明 charset 但是表声明了 charset 的时候,字段长度计算错误的问题(需要使用默认 charset)

这些问题都来源于解析 MySQL 8 的 mysql.user 表,可以采取下面的办法去测试。

  • show create table mysql.user 然后复制 sql 改下表名创建一张新表
  • insert into user1 select * from mysql.user 将数据搬过去
  • alter table user1 drop column User_attributes json 字段还不支持,无法解析,先 drop 掉(这个 feature 我看下能不能搞的定,可以的话,我之后再 pr https://github.com/alibaba/innodb-java-reader/issues/22)
  • 使用建表 sql 和数据文件进行测试

@CLAassistant
Copy link

CLAassistant commented May 26, 2021

CLA assistant check
All committers have signed the CLA.

@virusdefender virusdefender changed the title [WIP] bug fixes 修复一些小 bug May 27, 2021
@virusdefender
Copy link
Author

see #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants