Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renderer-core): added log when executing setState #1892

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@github-actions
Copy link

ChatGPT Code Review:

CodeReview:

代码看起来是在 React 项目中的生成一个页面的 renderer-core 模块添加了一个 log 日志。

  1. 引入了 @alilc/lowcode-utils 的方法:getLogger。
  2. 在 pageRendererFactory 函数内定义了一个 logger 对象。
  3. 在 PageRenderer 类中,重写了 setState 方法,并添加了一个 log,日志的级别是 info。
  4. 最后在 render 方法中根据条件进行了渲染。

建议修改:

  1. 定义的 logger 对象未在其他地方使用,建议考虑移除或者合并其他的读写日志的操作。
  2. 建议在 setState 方法中加上错误处理,例如 state 为 undefined 或 null 时给出错误提示。
  3. 在代码中使用的 getLog 可能会因为版本的更新而出现找不到方法的情况,建议给出一个文档或注释说明此方法的来源以及版本信息。
  4. 如果在代码中已经引入了 React Native 等代码审查同行未必了解的第三方类库时,建议在代码开头加上注释来进行说明。

生成的 commit message 建议:
feat(renderer-core): add log when executing setState in PageRenderer

原因:

  1. commit 类型为 feat,表示添加新功能。
  2. 改动部分为 pageRendererFactory 函数中的 PageRenderer 类中的 setState 方法,在其中添加 log。
  3. 修改的代码作用是在执行 setState 方法时输出一条日志,方便调试和问题定位。

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 996e741

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 996e741

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2846/2954
🟢 Branches 88.84% 1632/1837
🟢 Functions 95.98% 859/895
🟢 Lines 96.42% 2772/2875

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 996e741

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements
71.95% (-0.09% 🔻)
908/1262
🟡 Branches 61.23% 567/926
🟡 Functions
69.12% (-0.24% 🔻)
197/285
🟡 Lines
71.94% (-0.09% 🔻)
892/1240
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 renderer/page.tsx
68.97% (-4.11% 🔻)
50%
60% (-15% 🔻)
68.97% (-4.11% 🔻)

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 996e741

@JackLian JackLian merged commit 5c49044 into develop Apr 17, 2023
@JackLian JackLian deleted the feat/add-page-render-log branch April 17, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants