Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove editor api #1893

Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat: remove editor api #1893

merged 1 commit into from
Apr 17, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@github-actions
Copy link

ChatGPT Code Review:

CodeReview:

根据这份 diff,我发现该提交删除了 event 模块的别名 editor,也就是说,旧版代码中可以使用 editor 访问 event 模块的功能,现在需要直接使用 event。这个变化看起来没有问题,在一些情况下,将 event 模块和 editor 模块进行分离可能会更好。

修改建议:

我认为这个变化没有问题,建议保持不变。

Commit Message:

因为这个变更移除了重要的 API,所以在提交消息中使用 BREAKING CHANGE 标签是必要的。

feat: remove editor api

BREAKING CHANGE: remove the `editor` alias for the `event` module,  use `event` directly instead.

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from f71f9d4

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from f71f9d4

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.04% 907/1259
🟡 Branches 61.23% 567/926
🟡 Functions 69.37% 197/284
🟡 Lines 72.03% 891/1237

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from f71f9d4

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2846/2954
🟢 Branches 88.84% 1632/1837
🟢 Functions 95.98% 859/895
🟢 Lines 96.42% 2772/2875

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from f71f9d4

@JackLian JackLian merged commit 2c38c5d into develop Apr 17, 2023
@JackLian JackLian deleted the feat/remove-editor-api branch April 17, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants