Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): add enableAutoOpenFirstWindow config and onWindowRendererReady function #1910

Merged
merged 1 commit into from Apr 19, 2023

Conversation

liujuping
Copy link
Collaborator

…dererReady function

@liujuping liujuping changed the title feat(workspace): add enableAutoOpenFirstWindow config and onWindowRen… feat(workspace): add enableAutoOpenFirstWindow config and onWindowRendererReady function Apr 19, 2023
@github-actions
Copy link

ChatGPT Code Review:

Code Review:

  1. enableAutoOpenFirstWindow 配置项添加。此处修改非常地规范,增加新配置项时,需要在末尾新增一条,像这样 }; 就可以了。

  2. getStrictModeValue 函数未被使用到,是否考虑删除掉这个函数。

  3. registryInnerPlugin 函数的第二个参数类型传入了 Editor, 然而 diff 中显示的代码里实际上是 IEditor。需要确认一下 Editor 类型和 IEditor 类型的差别。

  4. WindowView 中的 active 属性使用

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from f324c86

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from f324c86

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from f324c86

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2846/2954
🟢 Branches 88.84% 1632/1837
🟢 Functions 95.98% 859/895
🟢 Lines 96.42% 2772/2875

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from f324c86

@JackLian JackLian merged commit 9b50bc7 into develop Apr 19, 2023
18 checks passed
@JackLian JackLian deleted the feat/workspace-enableAutoOpenFirstWindow branch April 19, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants