Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update setter types #1934

Merged
merged 1 commit into from Apr 21, 2023
Merged

feat: update setter types #1934

merged 1 commit into from Apr 21, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@github-actions
Copy link

ChatGPT Code Review:

CodeReview:

代码中主要做了以下几处修改:

  1. setter.ts 中引入了 IPublicApiSetters 接口,并在 Setters 类中声明实现该接口,以替代原有的直接实例化 IPublicTypeRegisteredSetter 对象的方式。
  2. setting-pane.tsx 中,将 Setters 类型的属性改为了 IPublicApiSetters 类型,并在 createSetterContent 方法中使用可选链 ?. 避免类型不匹配问题。
  3. setters.ts 中,将 Setters 类型的参数改为了 ISetters,并在 globalContext 中使用 untracked 包裹处理避免出现意外错误。

错误及修复建议:

未发现明显错误和 typo。

根据Angular规范生成合适的commit message:

chore: update setter types

根据修改内容和规范,本次 commit 可以归类为 chore 类型,commit message 为 update setter types

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 07dd83e

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 07dd83e

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 07dd83e

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2842/2950
🟢 Branches 88.83% 1630/1835
🟢 Functions 95.97% 858/894
🟢 Lines 96.41% 2769/2872

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 07dd83e

@JackLian JackLian merged commit aab8a3a into develop Apr 21, 2023
19 checks passed
@JackLian JackLian deleted the feat/setter-types-update branch April 21, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants