Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outline-pane): export OutlinePaneContext, add null option to setPluginContext and hideFilter option to Pane #1953

Merged
merged 1 commit into from Apr 26, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@github-actions
Copy link

ChatGPT Code Review:

CodeReview:

  1. OutlinePaneContext 组件用于导出 TreeMaster 的实例,更加方便其他组件调用。
  2. setPluginContext 函数参数类型新增 null 可选类型,做了更加完善的类型检测处理。
  3. 在 Pane 组件中加入了 hideFilter 可选属性,用于控制 Filter 组件的显示或隐藏。
  4. 代码风格清晰,规范性良好,无明显错误。

修改建议:

  1. 虽然 CodeReview 确保了代码规范性良好,但也需要注意一些细节问题,比如样式层级、注释等等,修改后的代码质量会更高。

生成的 commit message 如下:
feat(outline-pane): export OutlinePaneContext, add null option to setPluginContext and hideFilter option to Pane

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from cc768e6

@liujuping liujuping changed the title feat(outline-pane): export OutlinePaneContext feat(outline-pane): export OutlinePaneContext, add null option to setPluginContext and hideFilter option to Pane Apr 26, 2023
@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from cc768e6

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from cc768e6

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2842/2950
🟢 Branches 88.83% 1630/1835
🟢 Functions 95.97% 858/894
🟢 Lines 96.41% 2769/2872

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from cc768e6

@JackLian JackLian merged commit 5b14230 into develop Apr 26, 2023
19 checks passed
@JackLian JackLian deleted the feat/outlin-pane branch April 26, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants