Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): add config attribute to Resource shell model #1954

Merged
merged 1 commit into from Apr 26, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@github-actions
Copy link

ChatGPT Code Review:

CodeReview:

  1. 在 plugin-context.ts 中新增了两个属性 IPublicEnumPluginRegisterLevel 和 IPublicModelWindow。
  2. 在 Resource 类中新增了 config 属性。
  3. 在 Window 类中新增了当前视图为 null 的判断。
  4. 在 types/package.json 中新增了依赖。
  5. 在 resource.ts 中新增了 config 属性获取方法。

建议修改:

  1. 可以给每个新增属性和方法添加一些注释,方便理解代码。
  2. 新增的 config 属性可以补充一些读写的相关方法,方便使用。
  3. 视情况可以给新增的 IPublicModelWindow 的方法添加一些返回值为空的判断,增加代码健壮性。
  4. 可以更新 types/package.json,使其只依赖需要的包。

Commit message:
feat(workspace/model): add config attribute to Resource shell model

@liujuping liujuping changed the title feat(workspace): add config for resource shell model feat(workspace): add config attribute to Resource shell model Apr 26, 2023
@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 01b177a

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 01b177a

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 01b177a

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2842/2950
🟢 Branches 88.83% 1630/1835
🟢 Functions 95.97% 858/894
🟢 Lines 96.41% 2769/2872

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 01b177a

@JackLian JackLian merged commit c3d75b2 into develop Apr 26, 2023
19 checks passed
@JackLian JackLian deleted the feat/resource-config branch April 26, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants