Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moduleName of Component should not be converted #1991

Merged
merged 7 commits into from May 8, 2023

Conversation

@github-actions
Copy link

github-actions bot commented May 6, 2023

ChatGPT Code Review:

  1. 代码存在错误拼写,请将 ice3 改为 icejs3
  2. 代码的功能是更新了 lowcode-code-generator 包的版本号为 1.1.2,修改了 IPublicTypePanelDockConfig 接口中的 name 字段不能为可选的问题,并进行了一些代码重构,以解决一些已知问题。其中,SchemaParser.ts 文件中,通过新增一个 ContainerType 枚举类型和修改 isValidContainerType 函数来处理 container 类型(包括 Page、Component、Block)的代码片段。在 jsx.ts 文件中,插件的 pluginFactory 函数新增了一个 input.value 为空的判断。在 standalone.ts 文件中,增加了一个 styleImport 插件。

@github-actions
Copy link

github-actions bot commented May 6, 2023

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 8fc60c7

@github-actions
Copy link

github-actions bot commented May 6, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 8fc60c7

@github-actions
Copy link

github-actions bot commented May 6, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 8fc60c7

@github-actions
Copy link

github-actions bot commented May 6, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches 89.05% 1626/1826
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 8fc60c7

@LeoYuan
Copy link
Contributor Author

LeoYuan commented May 6, 2023

PS: 请勿使用 squash 合入,rebase / merge commit 均 OK~

@JackLian JackLian merged commit 9947a36 into develop May 8, 2023
16 checks passed
@JackLian JackLian deleted the chore/code-gen-comp branch May 8, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants