Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workspace add onChangeActiveWindow event api #2022

Merged
merged 1 commit into from May 11, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner May 11, 2023 02:12
@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from d453752

@github-actions
Copy link

ChatGPT Code Review:

  1. 代码看起来没有明显的拼写错误和语法错误。建议调整代码格式,在 Workspace 类的 onChangeActiveEditorView 方法后加上空行。
  2. diff 展示了对 Workspace 类、EditorView 类和 EditorWindow 类的修改。其中在 Workspace 类中新增了 onChangeActiveEditorView 方法,其作用是监听当前编辑器视图改变的事件。当当前窗口的视图类型被修改时,该方法会触发回调函数。在 EditorView 类中,针对 pluginName,新增了 editorView.editorWindow + editorView.viewName 的判断条件。在 EditorWindow 类中,当当前窗口的视图类型被修改时,除了默认的窗口改变事件外,还触发了 Workspace 类的 emitChangeActiveEditorView 方法。在 Workspace 类中,则新增了 onChangeActiveEditorView 方法和 emitChangeActiveEditorView 方法,用于监听当前编辑器视图改变的事件,并在视图类型修改时触发回调函数。

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from d453752

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from d453752

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches 89.05% 1626/1826
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from d453752

@JackLian JackLian merged commit 22d2fdd into develop May 11, 2023
19 checks passed
@JackLian JackLian deleted the feat/workspace-onChangeActiveWindow branch May 11, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants